Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/unittests m1 #1933

Merged
merged 22 commits into from
Aug 4, 2023
Merged

Fix/unittests m1 #1933

merged 22 commits into from
Aug 4, 2023

Conversation

dennisbader
Copy link
Collaborator

@dennisbader dennisbader commented Aug 4, 2023 •
edited
Loading

Summary

Fixes unit tests to run locally on M1 devices

  • run all torch models on CPU
    • by default most time series are float64 which is not supported by M1 GPU
    • not all torch functionalities that we use in our TorchForecastingModel are supported on M1 GPU
  • fixes a bug in TiDE model where it was not possible to predict with n < output_chunk_length

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023 •
edited
Loading

Codecov Report

Patch coverage: 90.00% and project coverage change: -0.02% ⚠️

Comparison is base (2f40d97) 93.88% compared to head (42e3f82) 93.87%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1933      +/-   ##
==========================================
- Coverage   93.88%   93.87%   -0.02%     
==========================================
  Files         132      132              
  Lines       12667    12655      -12     
==========================================
- Hits        11893    11880      -13     
- Misses        774      775       +1
Files Changed Coverage Δ
darts/models/forecasting/tft_model.py 97.25% <ø> (-0.03%) ⬇️
darts/models/forecasting/tide_model.py 97.32% <90.00%> (+0.09%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

madtoinou
madtoinou approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@madtoinou madtoinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments about typo or coherence

darts/tests/explainability/test_tft_explainer.py Outdated Show resolved Hide resolved
darts/tests/explainability/test_tft_explainer.py Outdated Show resolved Hide resolved
darts/tests/explainability/test_tft_explainer.py Outdated Show resolved Hide resolved
darts/tests/explainability/test_tft_explainer.py Show resolved Hide resolved
darts/tests/explainability/test_tft_explainer.py Outdated Show resolved Hide resolved
darts/tests/models/forecasting/test_TFT.py Outdated Show resolved Hide resolved
darts/tests/base_test_class.py Show resolved Hide resolved
darts/tests/models/forecasting/test_global_forecasting_models.py Outdated Show resolved Hide resolved
dennisbader and others added 3 commits August 4, 2023 11:27
@dennisbader @madtoinou
Apply suggestions from code review
d42d6cb 
Co-authored-by: madtoinou <32447896+madtoinou@users.noreply.github.com>
@dennisbader
fix linting issues
af38b2c
@dennisbader
update changelog
5ee8d14
@dennisbader dennisbader merged commit ac957a9 into master Aug 4, 2023
9 checks passed
@dennisbader dennisbader deleted the fix/unittests_m1 branch August 4, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madtoinou madtoinou madtoinou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dennisbader @codecov-commenter @madtoinou